[bazel] fix --config=shell #129194
Open
[bazel] fix --config=shell #129194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/129194
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 5362b84 with merge base 9dd8f8c ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
vors
force-pushed
the
sergei/bazel-fix-shell
branch
from
bb9a578
to
5362b84
Compare
janeyx99
added
the
triaged
|
It would be helpful to open a parallel issue motivating the issue and suggesting what the ideal state would be to allow for more discussion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quality of life improvement for bazel dev.
Previously on recent bazel the
bazel --config=shellwas getting into a bad state where nothing can be typed and the shell cannot be halted, so it's worse then useless.Unfortunately vanilla bazel doesn't have a good way to achieve the
--config=shellintent, but with thecat /dev/ttyis somewhat works (but no readline still).So this is mostly fixing what is broken, but still not in the ideal shape.