Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move caffe2/serialize to torch/csrc/api #129141

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

cyyever
Copy link
Collaborator

@cyyever cyyever commented Jun 20, 2024

Move caffe2/serialize to torch/csrc/api since it is used solely in jit code. The getRecordMultiReaders is removed since it has race conditions and is not used currently

cc @albanD

Copy link

pytorch-bot bot commented Jun 20, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/129141

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit b898b5f with merge base 10c7f03 (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: cpp release notes category label Jun 20, 2024
@cyyever cyyever changed the title Caffe2 onnx31 Move caffe2/serialize to torch/csrc/api Jun 20, 2024
@cyyever cyyever marked this pull request as draft June 20, 2024 23:37
@cyyever cyyever added suppress-bc-linter Suppresses the failures of API backward-compatibility linter (Lint/bc_linter) topic: bc breaking topic category better-engineering Relatively self-contained tasks for better engineering contributors labels Jun 20, 2024
@cyyever cyyever force-pushed the caffe2_onnx31 branch 3 times, most recently from e277212 to 11ad593 Compare June 21, 2024 02:28
@cyyever cyyever marked this pull request as ready for review June 21, 2024 02:46
@cyyever cyyever force-pushed the caffe2_onnx31 branch 2 times, most recently from 3f89a21 to 03b5c50 Compare June 21, 2024 04:34
@cyyever cyyever marked this pull request as draft June 21, 2024 04:39
@cyyever cyyever force-pushed the caffe2_onnx31 branch 5 times, most recently from 97a3782 to f5cba28 Compare June 21, 2024 09:46
@cyyever cyyever added the ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR label Jun 21, 2024
@cyyever cyyever force-pushed the caffe2_onnx31 branch 6 times, most recently from b4a094e to 80235d8 Compare June 25, 2024 02:37
@cyyever cyyever force-pushed the caffe2_onnx31 branch 3 times, most recently from 0360553 to dd103e7 Compare July 1, 2024 05:10
@cyyever
Copy link
Collaborator Author

cyyever commented Jul 4, 2024

@pytorchbot rebase -b main

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased caffe2_onnx31 onto refs/remotes/origin/main, please pull locally before adding more changes (for example, via git checkout caffe2_onnx31 && git pull --rebase)

@cyyever cyyever requested review from ezyang and r-barnes July 4, 2024 00:45
@cyyever cyyever marked this pull request as ready for review July 4, 2024 00:45
@cyyever cyyever added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 4, 2024
@ezyang ezyang removed their request for review July 5, 2024 19:04
@zou3519 zou3519 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jul 8, 2024
@cyyever
Copy link
Collaborator Author

cyyever commented Jul 13, 2024

@r-barnes Help review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
better-engineering Relatively self-contained tasks for better engineering contributors ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR ciflow/trunk Trigger trunk jobs on your pull request open source release notes: cpp release notes category skip-pr-sanity-checks suppress-bc-linter Suppresses the failures of API backward-compatibility linter (Lint/bc_linter) topic: bc breaking topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants