[Fix]: TSConverter errors on dynamic shapes #129087
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/129087
Note: Links to docs will display an error until the docs builds have been completed. ❌ 11 New FailuresAs of commit aac935d with merge base 67e22d6 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
jiashenC
force-pushed
the
fix_dynamic_shape
branch
from
950a032
to
3d19c8a
Compare
jiashenC
force-pushed
the
fix_dynamic_shape
branch
from
fa8808a
to
41ab6fc
Compare
jiashenC
force-pushed
the
fix_dynamic_shape
branch
from
b65aef2
to
6c821a9
Compare
jiashenC
force-pushed
the
fix_dynamic_shape
branch
from
6c821a9
to
78fc411
Compare
jiashenC
requested review from
avikchaudhuri,
gmagogsfm,
tugsbayasgalan and
zhxchen17
as code owners
angelayi
reviewed
Jul 17, 2024
torch/_subclasses/meta_utils.py
Outdated
| @@ -1448,7 +1455,7 @@ def is_c_of_r(complex_dtype, real_dtype): | |||
| device="meta", | |||
| ) | |||
| ) | |||
| if self.copy_data: | |||
| if self.copy_data and not has_symbolic_size(t.size): | |||
There was a problem hiding this comment.
Is @pianpwk the right person to confirm this is valid?
There was a problem hiding this comment.
could you make a separate PR with the changes in this file, and include a test case and have Ed take a look?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable dynamic shape support during conversion.
meta_utils.pyfor unbacked fake tensors.Test Plan
Add test cases that create dynamic shapes.
pytest test/export/test_converter.py -s -k test_ts2ep_dynamic_shapecc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames