Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ALI] Use lf runners for Lint #128978

Merged
merged 2 commits into from
Jun 19, 2024
Merged

[ALI] Use lf runners for Lint #128978

merged 2 commits into from
Jun 19, 2024

Conversation

ZainRizvi
Copy link
Contributor

Quick experiment with using LF runners for lint jobs.

Picking a set of jobs where infra failures would be obvious to most people

Copy link

pytorch-bot bot commented Jun 18, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/128978

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit c5a5091 with merge base 304c934 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Jun 18, 2024
@ZainRizvi ZainRizvi marked this pull request as ready for review June 18, 2024 18:05
@ZainRizvi ZainRizvi requested a review from a team as a code owner June 18, 2024 18:05
@jeanschmidt jeanschmidt merged commit 7fac03a into main Jun 19, 2024
104 checks passed
@jeanschmidt jeanschmidt deleted the zainr/lint-tf branch June 19, 2024 08:59
@jeanschmidt
Copy link
Contributor

@pytorchbot revert -m "Merged directly, this should not be done"

Copy link

pytorch-bot bot commented Jun 19, 2024

❌ 🤖 pytorchbot command failed:

@pytorchbot revert: error: the following arguments are required: -c/--classification

usage: @pytorchbot revert -m MESSAGE -c
                          {nosignal,ignoredsignal,landrace,weird,ghfirst}

Try @pytorchbot --help for more info.

@jeanschmidt
Copy link
Contributor

@pytorchbot revert -m "Merged directly, this should not be done" -c weird

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

@pytorchmergebot
Copy link
Collaborator

Reverting PR 128978 failed

Reason: Approvers from one of the following sets are needed:

  • OSS CI (alband, dagitses, pytorch/pytorch-dev-infra)
  • superuser (pytorch/metamates)
  • Core Reviewers (mruberry, lezcano, Skylion007, ngimel, peterbell10)
  • Core Maintainers (soumith, gchanan, ezyang, dzhulgakov, malfet)
Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

jeanschmidt added a commit that referenced this pull request Jun 19, 2024
pytorchmergebot pushed a commit that referenced this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants