Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mm pad regresion - more conservative estimation of plannable inputs #128909

Open
wants to merge 3 commits into
base: gh/eellison/660/base
Choose a base branch
from

Conversation

Copy link

pytorch-bot bot commented Jun 17, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/128909

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (15 Unrelated Failures)

As of commit 9ea21e2 with merge base 4c84af0 (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

eellison added a commit that referenced this pull request Jun 17, 2024
ghstack-source-id: 9fe5a18238f69419cc46be06c5ef9b20eb4a5e82
Pull Request resolved: #128909
…nnable inputs"

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang

[ghstack-poisoned]
eellison added a commit that referenced this pull request Jun 17, 2024
ghstack-source-id: 8fd6d645bf95aaaa6704b2209fa4d0e278611231
Pull Request resolved: #128909
…nnable inputs"

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang

[ghstack-poisoned]
eellison added a commit that referenced this pull request Jun 19, 2024
ghstack-source-id: 5b6ec98898b4cf64bbe68d458cc075c38d9e1da3
Pull Request resolved: #128909
# first dimension padding. non-first we would still need a copy
# because these outputs are fixed dense.
cannot_plan_output = [
aten.mm.default,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just because we force the layout with max-autotune today, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, i can exclude this when not in max-autotune. Although we'd still need to exclude when padding non first dim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants