Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix]: Internal test failures when testing the exportability #128900

Closed
wants to merge 4 commits into from
Closed

[Fix]: Internal test failures when testing the exportability #128900

wants to merge 4 commits into from

Conversation

jiashenC
Copy link
Contributor

@jiashenC jiashenC commented Jun 17, 2024 •
edited
Loading

Issue

EP modifies the internal state of module / inputs. This PR sends a copy to log exportability instead.

Test Plan

  • pytest test/jit/test_tracer.py

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 17, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/128900

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 332cbc8 with merge base c2d0b7b (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: jit release notes category label Jun 18, 2024
@jiashenC jiashenC marked this pull request as ready for review June 18, 2024 18:36
@jiashenC jiashenC added topic: not user facing topic category and removed release notes: jit release notes category labels Jun 18, 2024
@facebook-github-bot
Copy link
Contributor

@jiashenC has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@jiashenC has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@jiashenC has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

1 similar comment
@facebook-github-bot
Copy link
Contributor

@jiashenC has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@jiashenC jiashenC force-pushed the fix_failed_jit_trace_tests branch from fca845d to 332cbc8 Compare July 2, 2024 04:31
@facebook-github-bot
Copy link
Contributor

@jiashenC has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@jiashenC
Copy link
Contributor Author

jiashenC commented Jul 5, 2024

Fixed internally

@jiashenC jiashenC closed this Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angelayi angelayi angelayi approved these changes

@tugsbayasgalan tugsbayasgalan Awaiting requested review from tugsbayasgalan

Assignees
No one assigned
Labels
ciflow/inductor topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jiashenC @facebook-github-bot @angelayi