-
Notifications
You must be signed in to change notification settings - Fork 22k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NOT NEEDED][Traceable FSDP2] Fixes to preserve inplace ops in AOT joint graph and fwd graph #128886
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 17, 2024
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/128886
Note: Links to docs will display an error until the docs builds have been completed. ❌ 32 New FailuresAs of commit 7a87703 with merge base d3b8230 (): NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
ciflow/inductor
oncall: distributed
Add this issue/PR to distributed oncall triage queue
release notes: distributed (fsdp)
release notes category
labels
Jun 17, 2024
yf225
changed the title
Fixes to preserve inplace ops in AOT joint graph and fwd graph
[Traceable FSDP2] Fixes to preserve inplace ops in AOT joint graph and fwd graph
Jun 17, 2024
yf225
added a commit
that referenced
this pull request
Jun 17, 2024
ghstack-source-id: 12813ec96046c85fe45a71d095f31e0a5ab75d55 Pull Request resolved: #128886
yf225
added a commit
that referenced
this pull request
Jun 17, 2024
ghstack-source-id: edc3354704b9a35fb4ce6cf365756881784ad642 Pull Request resolved: #128886
yf225
added a commit
that referenced
this pull request
Jun 18, 2024
ghstack-source-id: 98acf1b43448cb98ec642d9ff23de11a238943d1 Pull Request resolved: #128886
yf225
added a commit
that referenced
this pull request
Jun 19, 2024
ghstack-source-id: 4893f13bf75a44b94b59457cb3369bf52aa13421 Pull Request resolved: #128886
yf225
changed the title
[Traceable FSDP2] Fixes to preserve inplace ops in AOT joint graph and fwd graph
[NOT NEEDED][Traceable FSDP2] Fixes to preserve inplace ops in AOT joint graph and fwd graph
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ciflow/inductor
oncall: distributed
Add this issue/PR to distributed oncall triage queue
release notes: distributed (fsdp)
release notes category
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
cc @mrshenli @pritamdamania87 @zhaojuanmao @satgera @gqchen @aazzolini @osalpekar @jiayisuse @H-Huang @kwen2501 @awgu @penguinwu @fegin @XilunWu @wanchaol @fduwjj @wz337 @tianyu-l @wconstab @chauhang @d4l3k