Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[caffe2][be] migrate global static initializer - version_map #128831

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[caffe2][be] migrate global static initializer - version_map #128831

wants to merge 1 commit into from

Conversation

klein-meta
Copy link
Contributor

Summary: Caffe2 lib has 200+ global static initializer usage, which are papar-cut reference to startup perf. Detail in this post https://fb.workplace.com/groups/arglassesperf/permalink/623909116287154.

Test Plan: CI

Differential Revision: D58643791

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 17, 2024

This appears to be a diff that was exported from phabricator, but the PR author does not have sufficient permissions to run CI. @klein-meta, please do step 2 of internal wiki to get write access so you do not need to get CI approvals in the future. If you think this is a mistake, please contact the Pytorch Dev Infra team.

@pytorch-bot pytorch-bot bot added the release notes: jit release notes category label Jun 17, 2024
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 17, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/128831

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 37cdfeb with merge base b9d3ced (image):

NEW FAILURE - The following job has failed:

  • trunk / macos-py3-arm64 / build (gh)
    /Users/ec2-user/runner/_work/pytorch/pytorch/torch/csrc/jit/operator_upgraders/version_map.cpp:17:62: error: no previous prototype for function 'getOperatorVersionMap' [-Werror,-Wmissing-prototypes]

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58643791

@aaronenyeshi aaronenyeshi added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 19, 2024
aaronenyeshi
aaronenyeshi approved these changes Jun 27, 2024
View reviewed changes
Copy link
Member

@aaronenyeshi aaronenyeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the CI issues, may be occuring on another diff lower in the stack

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58643791

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58643791

@klein-meta @facebook-github-bot
[caffe2][be] migrate global static initializer - version_map (pytorch…
37cdfeb 
…#128831)

Summary:
Pull Request resolved: pytorch#128831

Caffe2 lib has 200+ global static initializer usage, which are papar-cut reference to startup perf. Detail in this post https://fb.workplace.com/groups/arglassesperf/permalink/623909116287154.

Test Plan: CI

Reviewed By: aaronenyeshi

Differential Revision: D58643791
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58643791

@github-actions GitHub Actions
Copy link

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the Stale label Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronenyeshi aaronenyeshi aaronenyeshi approved these changes

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request fb-exported release notes: jit release notes category Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@klein-meta @facebook-github-bot @aaronenyeshi