Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused type traits in torch/csrc/utils #128799

Closed
wants to merge 1 commit into from
Closed

Remove unused type traits in torch/csrc/utils #128799

wants to merge 1 commit into from

Conversation

cyyever
Copy link
Collaborator

@cyyever cyyever commented Jun 17, 2024 •
edited
Loading

Follows #127852

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 17, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/128799

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 6a1262e with merge base f9dae86 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@cyyever cyyever changed the title Concate namespace and remove unused type traits in torch/csrc/utils Remove unused type traits in torch/csrc/utils Jun 17, 2024
@cyyever cyyever added the topic: not user facing topic category label Jun 17, 2024
@mikaylagawarecki mikaylagawarecki added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jun 17, 2024
albanD
albanD reviewed Jun 21, 2024
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't these technically public API for our cpp API?

@cyyever
Copy link
Collaborator Author

cyyever commented Jun 21, 2024

But I think they should be replaced by STL trails, and in deed all uses have been replaced.

@albanD
Copy link
Collaborator

albanD commented Jun 21, 2024

Sure we should migrate, just asking if we did all the checks that there is no more use and assessment if we need a deprecation cycle.

@cyyever
Copy link
Collaborator Author

cyyever commented Jun 21, 2024

Can't find other uses in GitHub projects. But I don't know if there are still references inside META.

@ezyang
Copy link
Contributor

ezyang commented Jun 27, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 27, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@cyyever cyyever deleted the tidy_utils2 branch June 28, 2024 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albanD albanD albanD left review comments

@ezyang ezyang ezyang approved these changes

@Skylion007 Skylion007 Awaiting requested review from Skylion007

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@cyyever @albanD @ezyang @pytorchmergebot @pytorchbot @mikaylagawarecki