[caffe2][be] migrate gloabl static initializer #128784
Conversation
|
This appears to be a diff that was exported from phabricator, but the PR author does not have sufficient permissions to run CI. @klein-meta, please do step 2 of internal wiki to get write access so you do not need to get CI approvals in the future. If you think this is a mistake, please contact the Pytorch Dev Infra team. |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/128784
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 35aa619 with merge base c4dd752 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D58639283 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D58639283 |
Summary: Pull Request resolved: pytorch#128784 Caffe2 lib has 200+ global static initializer usage, which are papar-cut reference to startup perf. Detail in this post https://fb.workplace.com/groups/arglassesperf/permalink/623909116287154. This Diff migrate StorageImpl.cpp Addtional Context: https://fb.workplace.com/groups/arglassesperf/permalink/623909116287154 Test Plan: CI Differential Revision: D58639283
klein-meta
force-pushed
the
export-D58639283
branch
from
6bbc2a2
to
d47f7d6
Compare
There was a problem hiding this comment.
Please fix lint before landing:
2024-06-19T15:56:10.5610812Z Warning (CLANGFORMAT) format
2024-06-19T15:56:10.5611379Z See https://clang.llvm.org/docs/ClangFormat.html.
2024-06-19T15:56:10.5611957Z Run `lintrunner -a` to apply this patch.
2024-06-19T15:56:10.5612304Z
2024-06-19T15:56:10.5612579Z You can run `lintrunner -a` to apply this patch.
2024-06-19T15:56:10.5612975Z
2024-06-19T15:56:10.5613465Z 10 10 | // A allowlist of device type, currently available is PrivateUse1.
2024-06-19T15:56:10.5614575Z 11 11 | ska::flat_hash_set<c10::DeviceType>& DeviceTypeAllowList() {
2024-06-19T15:56:10.5615633Z 12 12 | static ska::flat_hash_set<c10::DeviceType> deviceTypeAllowList{
2024-06-19T15:56:10.5616623Z 12 |- DeviceType::PrivateUse1};
2024-06-19T15:56:10.5617514Z 13 |+ DeviceType::PrivateUse1};
2024-06-19T15:56:10.5618278Z 14 14 | return deviceTypeAllowList;
2024-06-19T15:56:10.5618859Z 15 15 | }
2024-06-19T15:56:10.5619319Z 16 16 |
2024-06-19T15:56:10.5619703Z
Summary: Pull Request resolved: pytorch#128784 Caffe2 lib has 200+ global static initializer usage, which are papar-cut reference to startup perf. Detail in this post https://fb.workplace.com/groups/arglassesperf/permalink/623909116287154. This Diff migrate StorageImpl.cpp Addtional Context: https://fb.workplace.com/groups/arglassesperf/permalink/623909116287154 Test Plan: CI Reviewed By: aaronenyeshi Differential Revision: D58639283
klein-meta
force-pushed
the
export-D58639283
branch
from
d47f7d6
to
35aa619
Compare
|
This pull request was exported from Phabricator. Differential Revision: D58639283 |
|
@pytorchbot merge -f 'Landed internally' (Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally) |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Summary:
Caffe2 lib has 200+ global static initializer usage, which are papar-cut reference to startup perf. Detail in this post https://fb.workplace.com/groups/arglassesperf/permalink/623909116287154.
This Diff migrate StorageImpl.cpp
Addtional Context: https://fb.workplace.com/groups/arglassesperf/permalink/623909116287154
Test Plan: CI
Differential Revision: D58639283