Raise exception if torch.func.* calls torch.compile functions #128736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/128736
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (3 Unrelated Failures)As of commit 2edd494 with merge base f389bca ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
guilhermeleobas
added a commit
that referenced
this pull request
Jun 14, 2024
ghstack-source-id: 790460103b03d70b99855662d2c3f58e57ca2908 Pull Request resolved: #128736
guilhermeleobas
added a commit
that referenced
this pull request
Jun 18, 2024
ghstack-source-id: ed45aa82f7c8477867ebcd0d8e7768049209f3c1 Pull Request resolved: #128736
guilhermeleobas
changed the title
guilhermeleobas
commented
Jun 18, 2024
torch/_dynamo/symbolic_convert.py
Outdated
Comment on lines
2449
to
2450
| # Is there a better way to detect this? | ||
| from_eager = counters.get("graph_break", None) is None |
There was a problem hiding this comment.
This is 100% wrong.
There was a problem hiding this comment.
If any of the inputs is a functorch tensor and the backend is not eager, raise a graph break.
zou3519
reviewed
Jul 29, 2024
Comment on lines
+5288
to
+5300
| def test_vmap_call_torch_compile_fn(self): | ||
| def wrapped_fn(x): | ||
| return x.sin() | ||
|
|
||
| x = torch.randn(3, 4) | ||
| fn = torch.compile(backend="aot_eager", fullgraph=True)(wrapped_fn) | ||
|
|
||
| with self.assertRaisesRegex( | ||
| torch._dynamo.exc.Unsupported, | ||
| "Calling torch.func.vmap\\(compiled_fn\\) function from eager mode is not supported", | ||
| ): | ||
| torch.func.vmap(fn)(x) | ||
|
|
There was a problem hiding this comment.
This graph breaks today:
import torch
def wrapped_fn(x):
return x.sin()
x = torch.randn(3, 4)
fn = torch.compile(backend="aot_eager")(wrapped_fn)
torch.vmap(fn)(x)
guilhermeleobas
added a commit
that referenced
this pull request
Jul 29, 2024
ghstack-source-id: 409c03af178c6e4b3ac121210f3a1d2e59d156d9 Pull Request resolved: #128736
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang