Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the decomposition of aten.threshold #128707

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alanhe151220037
Copy link
Contributor

Fixes #118642
fix the decomposition of aten.threshold to make its output consistent with eager mode when input tensor is intergral and threshold is a negative float.

Copy link

pytorch-bot bot commented Jun 14, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/128707

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Unrelated Failure

As of commit 95d6204 with merge base c76a9d1 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@alanhe151220037
Copy link
Contributor Author

@mlazos Do the workflows require some approval ?

@mikaylagawarecki mikaylagawarecki added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jun 17, 2024
Copy link
Contributor

@eellison eellison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good - mind adding a test ? you can add it in test_decomp

@alanhe151220037
Copy link
Contributor Author

alanhe151220037 commented Jun 18, 2024

looks good - mind adding a test ? you can add it in test_decomp

of course, I have added the test case here and it will be run in test_comprehensive_nn_functional_threshold_*.

https://github.com/pytorch/pytorch/blob/95d620481cd6322d36d30fdaec7b687d7e4ff1c6/torch/testing/_internal/common_methods_invocations.py#L3356-L3358

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Different outputs of div and threshold with a specific input
4 participants