Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

put split memory block in the front of memory block set when stream and size equal. #128674

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Shan19900305
Copy link
Contributor

@Shan19900305 Shan19900305 commented Jun 14, 2024

Using split memory block first and will reduce memory fragment.

@Shan19900305 Shan19900305 requested a review from eqy as a code owner June 14, 2024 01:17
Copy link

pytorch-bot bot commented Jun 14, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/128674

Note: Links to docs will display an error until the docs builds have been completed.

❌ 6 New Failures

As of commit cc1b9b6 with merge base 638f543 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@eqy
Copy link
Collaborator

eqy commented Jun 14, 2024

Cool! do you have a small script demoing the effect of this change on an example workload?

@Shan19900305
Copy link
Contributor Author

Cool! do you have a small script demoing the effect of this change on an example workload?

Thx, Is there a memory fragmentation test case in the community?

@soulitzer soulitzer requested a review from zdevito June 14, 2024 13:22
@mikaylagawarecki mikaylagawarecki added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants