Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1/N] Enable unused variable warnings on torch_cpu and fix some violations #128670

Closed
wants to merge 8 commits into from

Conversation

cyyever
Copy link
Collaborator

@cyyever cyyever commented Jun 14, 2024

Copy link

pytorch-bot bot commented Jun 14, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/128670

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure, 1 Cancelled Job, 17 Unrelated Failures

As of commit 5e11812 with merge base eb1583d (image):

NEW FAILURE - The following job has failed:

CANCELLED JOB - The following job was cancelled. Please retry:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@cyyever cyyever marked this pull request as draft June 14, 2024 02:55
@cyyever cyyever force-pushed the torch_cpu_warning branch 3 times, most recently from 4e58c3d to 8c76b5d Compare June 14, 2024 15:30
@pytorch-bot pytorch-bot bot added the module: cpu CPU specific problem (e.g., perf, algorithm) label Jun 14, 2024
@cyyever cyyever added the ciflow/binaries Trigger all binary build and upload jobs on the PR label Jun 19, 2024
@cyyever
Copy link
Collaborator Author

cyyever commented Jun 19, 2024

@pytorchbot rebase -b main

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased torch_cpu_warning onto refs/remotes/origin/main, please pull locally before adding more changes (for example, via git checkout torch_cpu_warning && git pull --rebase)

@cyyever
Copy link
Collaborator Author

cyyever commented Jun 20, 2024

@pytorchbot rebase -b main

@cyyever cyyever added the ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR label Jun 20, 2024
@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased torch_cpu_warning onto refs/remotes/origin/main, please pull locally before adding more changes (for example, via git checkout torch_cpu_warning && git pull --rebase)

@pytorch-bot pytorch-bot bot added the release notes: sparse release notes category label Jun 20, 2024
@cyyever cyyever force-pushed the torch_cpu_warning branch 3 times, most recently from f137a02 to 5202bee Compare June 21, 2024 07:29
@pytorch-bot pytorch-bot bot added the NNC label Jun 21, 2024
@cyyever cyyever force-pushed the torch_cpu_warning branch 3 times, most recently from 29e12fe to 8a5b75f Compare June 21, 2024 09:11
@cyyever cyyever marked this pull request as ready for review June 21, 2024 09:11
@cyyever cyyever changed the title Enable more torch_cpu warnings Enable unused variable warnings on torch_cpu and fix some violations Jun 21, 2024
@cyyever cyyever changed the title Enable unused variable warnings on torch_cpu and fix some violations [1/N] Enable unused variable warnings on torch_cpu and fix some violations Jun 21, 2024
@cyyever cyyever requested review from albanD and r-barnes June 21, 2024 09:12
@drisspg drisspg added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jun 22, 2024
@cyyever
Copy link
Collaborator Author

cyyever commented Jul 1, 2024

@pytorchbot rebase -b main

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased torch_cpu_warning onto refs/remotes/origin/main, please pull locally before adding more changes (for example, via git checkout torch_cpu_warning && git pull --rebase)

@cyyever
Copy link
Collaborator Author

cyyever commented Jul 1, 2024

@pytorchmergebot merge -f "Failures are unrelated"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@cyyever cyyever deleted the torch_cpu_warning branch July 1, 2024 15:14
pytorchmergebot pushed a commit to khushi-411/pytorch that referenced this pull request Jul 2, 2024
pytorchmergebot pushed a commit that referenced this pull request Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/binaries Trigger all binary build and upload jobs on the PR ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR Merged module: cpu CPU specific problem (e.g., perf, algorithm) NNC open source release notes: sparse release notes category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants