-
Notifications
You must be signed in to change notification settings - Fork 21.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created docs for make_fx in torch.fx.experimental.proxy_tensor #128441
base: main
Are you sure you want to change the base?
Conversation
@pytorchbot rebase |
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
Successfully rebased |
12fc512
to
6010e69
Compare
You need to fix CI here by adding :noindex: to one of the instances. |
Thanks, I was just working on it and tracking down the problem so thanks for the solution! I will amend the commit soon |
@svekars I believe the problem is raised because |
@pytorchbot rebase |
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
Successfully rebased |
fafc433
to
3b7c81c
Compare
Fixes #127886
Description
Created docs to document the make_fx function to solve the issue #127886.
The variable names were pretty descriptive so I added what would be the functionality of some of them. The way this function seems to be used across users is always initializing it with a call, so that is why in the Return section I added what will be the return when called.
My logic for the examples was to demonstrate in Example 1 the raw functionality and Example 2 an actual usage of the function. Let me know if you think Example 1 is not necesary.
Summary of Changes
Checklist
cc @svekars @brycebortree @ezyang @SherlockNoMad @EikanWang @jgong5 @wenzhe-nrv