Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created docs for make_fx in torch.fx.experimental.proxy_tensor #128441

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ignaciobartol
Copy link
Contributor

@ignaciobartol ignaciobartol commented Jun 11, 2024

Fixes #127886

Description

Created docs to document the make_fx function to solve the issue #127886.
The variable names were pretty descriptive so I added what would be the functionality of some of them. The way this function seems to be used across users is always initializing it with a call, so that is why in the Return section I added what will be the return when called.

My logic for the examples was to demonstrate in Example 1 the raw functionality and Example 2 an actual usage of the function. Let me know if you think Example 1 is not necesary.

Summary of Changes

  • Added docs for torch.fx.experimental.proxy_tensor.make_fx
  • Added the proxy_tensor.make_fx function in the autosummary of docs/source/fx.experimental.rst

Checklist

  • The issue that is being fixed is referred in the description
  • Only one issue is addressed in this pull request
  • Labels from the issue that this PR is fixing are added to this pull request
  • No unnecesary issues are included into this pull request

cc @svekars @brycebortree @ezyang @SherlockNoMad @EikanWang @jgong5 @wenzhe-nrv

Copy link

pytorch-bot bot commented Jun 11, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/128441

Note: Links to docs will display an error until the docs builds have been completed.

❌ 10 New Failures, 12 Unrelated Failures

As of commit 3b7c81c with merge base 50567f7 (image):

NEW FAILURES - The following jobs have failed:

UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: fx release notes category label Jun 11, 2024
@github-actions github-actions bot added docathon-h1-2024 medium Label for medium docathon tasks module: docs Related to our documentation, both in docs/ and docblocks triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Jun 11, 2024
@brycebortree brycebortree requested a review from albanD June 12, 2024 16:21
@svekars
Copy link
Contributor

svekars commented Jun 17, 2024

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased docs-make_fx onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout docs-make_fx && git pull --rebase)

@svekars
Copy link
Contributor

svekars commented Jun 17, 2024

You need to fix CI here by adding :noindex: to one of the instances.

@ignaciobartol
Copy link
Contributor Author

You need to fix CI here by adding :noindex: to one of the instances.

Thanks, I was just working on it and tracking down the problem so thanks for the solution! I will amend the commit soon

@ignaciobartol
Copy link
Contributor Author

You need to fix CI here by adding :noindex: to one of the instances.

@svekars I believe the problem is raised because torch.fx.experimental.proxy_tensor it is also mentioned in fx.rst L1146. Should I add :noindex: to the .. automodule:: directive I added? or would be better to delete that line from fx.rst that is added for coverage but does not add anything to the docs?

@ignaciobartol
Copy link
Contributor Author

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased docs-make_fx onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout docs-make_fx && git pull --rebase)

@ignaciobartol
Copy link
Contributor Author

Hi @albanD I fixed the CI and the PR is ready to be reviewed :). Thanks!

cc @svekars

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/inductor docathon-h1-2024 medium Label for medium docathon tasks module: docs Related to our documentation, both in docs/ and docblocks oncall: fx open source release notes: fx release notes category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document the torch.fx.experimental.proxy_tensor.make_fx function
4 participants