Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROCm] Enable F8 Inductor Unit tests #128353

Closed
wants to merge 4 commits into from

Conversation

alugorey
Copy link
Contributor

@alugorey alugorey commented Jun 10, 2024

Copy link

pytorch-bot bot commented Jun 10, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/128353

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (13 Unrelated Failures)

As of commit 21be9b5 with merge base 61fa3de (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added module: inductor module: rocm AMD GPU support for Pytorch labels Jun 10, 2024
@alugorey
Copy link
Contributor Author

alugorey commented Jun 11, 2024

@jithunnair-amd switches on roughly 65 tests on MI300:


Ran 65 tests in 25.853s OK (skipped=32)

@colesbury colesbury requested a review from jeffdaily June 12, 2024 01:35
@colesbury colesbury added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jun 12, 2024
@jithunnair-amd jithunnair-amd added ciflow/trunk Trigger trunk jobs on your pull request rocm This tag is for PRs from ROCm team ciflow/rocm rocm priority high priority ROCm PRs from performance or other aspects labels Jun 12, 2024
@alugorey
Copy link
Contributor Author

@jeffdaily @colesbury @jithunnair-amd
This is ready for a final look. Double checked the failing unit tests and they're all unrelated.

@jithunnair-amd jithunnair-amd requested review from colesbury, malfet, jansel and eellison and removed request for colesbury June 20, 2024 21:21
@jithunnair-amd
Copy link
Collaborator

@pytorchbot merge -f "Unrelated CI failures"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/inductor ciflow/rocm ciflow/trunk Trigger trunk jobs on your pull request Merged module: inductor module: rocm AMD GPU support for Pytorch open source rocm priority high priority ROCm PRs from performance or other aspects rocm This tag is for PRs from ROCm team triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants