Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cuDNN][Quantization] Don't print when plan finalization fails in cuDNN quantization backend #128177

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

eqy
Copy link
Collaborator

@eqy eqy commented Jun 7, 2024

Similar in spirit to #125790, hopefully addresses failures seen for cuDNN 9.1 upgrade: ##128166

CC @nWEIdia @atalman

cc @csarofeen @ptrblck @xwang233 @jerryzh168 @jianyuh @raghuramank100 @jamesr66a @vkuzo @jgong5 @Xia-Weiwen @leslie-fang-intel @msaroufim

@eqy eqy added module: cudnn Related to torch.backends.cudnn, and CuDNN support oncall: quantization Quantization support in PyTorch open source topic: not user facing topic category labels Jun 7, 2024
@eqy eqy requested a review from jerryzh168 as a code owner June 7, 2024 00:10
Copy link

pytorch-bot bot commented Jun 7, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/128177

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit 6bc236a with merge base 7ede78f (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: quantization release notes category label Jun 7, 2024
@eqy eqy added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 7, 2024
Copy link
Collaborator

@nWEIdia nWEIdia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Skylion007
Copy link
Collaborator

Skylion007 commented Jun 11, 2024

Nit: can we log this, just not print it out to stdout/stderr? Logging them under debug could still be useful?

@eqy
Copy link
Collaborator Author

eqy commented Jun 11, 2024

Re: logging we can follow up on this but at the moment it's unclear if cuDNN is interested in addressing this issue---I'll check to see if they consider finalization failures a problem. I've also heard rumors that they were moving away from "incremental" finalization---finalizing all plans at once which may no longer expose this to PyTorch.

@eqy
Copy link
Collaborator Author

eqy commented Jun 11, 2024

@pytorchmergebot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@clee2000
Copy link
Contributor

@pytorchbot revert -m "broke test/test_quantization.py::TestQuantizedLinear::test_qlinear_cudnn on sm86 tests https://hud.pytorch.org/pytorch/pytorch/commit/cac7a22b92478d897488688010e562b7bd36b97f https://github.com/pytorch/pytorch/actions/runs/9470648757/job/26100448913. Probably a landrace, test ran on the PR and succeed" -c landrace

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot added a commit that referenced this pull request Jun 12, 2024
…s in cuDNN quantization backend (#128177)"

This reverts commit cac7a22.

Reverted #128177 on behalf of https://github.com/clee2000 due to broke test/test_quantization.py::TestQuantizedLinear::test_qlinear_cudnn on sm86 tests https://hud.pytorch.org/pytorch/pytorch/commit/cac7a22b92478d897488688010e562b7bd36b97f https://github.com/pytorch/pytorch/actions/runs/9470648757/job/26100448913.  Probably a landrace, test ran on the PR and succeed ([comment](#128177 (comment)))
@pytorchmergebot
Copy link
Collaborator

@eqy your PR has been successfully reverted.

@eqy
Copy link
Collaborator Author

eqy commented Jun 14, 2024

@pytorchmergebot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Rebase failed due to

Aborting rebase because rebasing the branch resulted in the same sha as the target branch.
This usually happens because the PR has already been merged.  Please rebase locally and push.

Raised by https://github.com/pytorch/pytorch/actions/runs/9509110096

TharinduRusira pushed a commit to TharinduRusira/pytorch that referenced this pull request Jun 14, 2024
…NN quantization backend (pytorch#128177)

Similar in spirit to pytorch#125790, hopefully addresses failures seen for cuDNN 9.1 upgrade: #pytorch#128166

CC @nWEIdia @atalman

Pull Request resolved: pytorch#128177
Approved by: https://github.com/nWEIdia, https://github.com/Skylion007
TharinduRusira pushed a commit to TharinduRusira/pytorch that referenced this pull request Jun 14, 2024
…s in cuDNN quantization backend (pytorch#128177)"

This reverts commit cac7a22.

Reverted pytorch#128177 on behalf of https://github.com/clee2000 due to broke test/test_quantization.py::TestQuantizedLinear::test_qlinear_cudnn on sm86 tests https://hud.pytorch.org/pytorch/pytorch/commit/cac7a22b92478d897488688010e562b7bd36b97f https://github.com/pytorch/pytorch/actions/runs/9470648757/job/26100448913.  Probably a landrace, test ran on the PR and succeed ([comment](pytorch#128177 (comment)))
ignaciobartol pushed a commit to ignaciobartol/pytorch that referenced this pull request Jun 14, 2024
…NN quantization backend (pytorch#128177)

Similar in spirit to pytorch#125790, hopefully addresses failures seen for cuDNN 9.1 upgrade: #pytorch#128166

CC @nWEIdia @atalman

Pull Request resolved: pytorch#128177
Approved by: https://github.com/nWEIdia, https://github.com/Skylion007
ignaciobartol pushed a commit to ignaciobartol/pytorch that referenced this pull request Jun 14, 2024
…s in cuDNN quantization backend (pytorch#128177)"

This reverts commit cac7a22.

Reverted pytorch#128177 on behalf of https://github.com/clee2000 due to broke test/test_quantization.py::TestQuantizedLinear::test_qlinear_cudnn on sm86 tests https://hud.pytorch.org/pytorch/pytorch/commit/cac7a22b92478d897488688010e562b7bd36b97f https://github.com/pytorch/pytorch/actions/runs/9470648757/job/26100448913.  Probably a landrace, test ran on the PR and succeed ([comment](pytorch#128177 (comment)))
@eqy
Copy link
Collaborator Author

eqy commented Jun 19, 2024

@pytorchmergebot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Rebase failed due to

Aborting rebase because rebasing the branch resulted in the same sha as the target branch.
This usually happens because the PR has already been merged.  Please rebase locally and push.

Raised by https://github.com/pytorch/pytorch/actions/runs/9578696353

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged module: cudnn Related to torch.backends.cudnn, and CuDNN support oncall: quantization Quantization support in PyTorch open source release notes: quantization release notes category Reverted topic: not user facing topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants