-
Notifications
You must be signed in to change notification settings - Fork 21.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cuDNN][Quantization] Don't print when plan finalization fails in cuDNN quantization backend #128177
base: main
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/128177
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit 6bc236a with merge base 7ede78f (): FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Nit: can we log this, just not print it out to stdout/stderr? Logging them under debug could still be useful? |
Re: logging we can follow up on this but at the moment it's unclear if cuDNN is interested in addressing this issue---I'll check to see if they consider finalization failures a problem. I've also heard rumors that they were moving away from "incremental" finalization---finalizing all plans at once which may no longer expose this to PyTorch. |
@pytorchmergebot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
@pytorchbot revert -m "broke test/test_quantization.py::TestQuantizedLinear::test_qlinear_cudnn on sm86 tests https://hud.pytorch.org/pytorch/pytorch/commit/cac7a22b92478d897488688010e562b7bd36b97f https://github.com/pytorch/pytorch/actions/runs/9470648757/job/26100448913. Probably a landrace, test ran on the PR and succeed" -c landrace |
@pytorchbot successfully started a revert job. Check the current status here. |
…s in cuDNN quantization backend (#128177)" This reverts commit cac7a22. Reverted #128177 on behalf of https://github.com/clee2000 due to broke test/test_quantization.py::TestQuantizedLinear::test_qlinear_cudnn on sm86 tests https://hud.pytorch.org/pytorch/pytorch/commit/cac7a22b92478d897488688010e562b7bd36b97f https://github.com/pytorch/pytorch/actions/runs/9470648757/job/26100448913. Probably a landrace, test ran on the PR and succeed ([comment](#128177 (comment)))
@eqy your PR has been successfully reverted. |
@pytorchmergebot rebase |
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
Rebase failed due to
Raised by https://github.com/pytorch/pytorch/actions/runs/9509110096 |
…NN quantization backend (pytorch#128177) Similar in spirit to pytorch#125790, hopefully addresses failures seen for cuDNN 9.1 upgrade: #pytorch#128166 CC @nWEIdia @atalman Pull Request resolved: pytorch#128177 Approved by: https://github.com/nWEIdia, https://github.com/Skylion007
…s in cuDNN quantization backend (pytorch#128177)" This reverts commit cac7a22. Reverted pytorch#128177 on behalf of https://github.com/clee2000 due to broke test/test_quantization.py::TestQuantizedLinear::test_qlinear_cudnn on sm86 tests https://hud.pytorch.org/pytorch/pytorch/commit/cac7a22b92478d897488688010e562b7bd36b97f https://github.com/pytorch/pytorch/actions/runs/9470648757/job/26100448913. Probably a landrace, test ran on the PR and succeed ([comment](pytorch#128177 (comment)))
…NN quantization backend (pytorch#128177) Similar in spirit to pytorch#125790, hopefully addresses failures seen for cuDNN 9.1 upgrade: #pytorch#128166 CC @nWEIdia @atalman Pull Request resolved: pytorch#128177 Approved by: https://github.com/nWEIdia, https://github.com/Skylion007
…s in cuDNN quantization backend (pytorch#128177)" This reverts commit cac7a22. Reverted pytorch#128177 on behalf of https://github.com/clee2000 due to broke test/test_quantization.py::TestQuantizedLinear::test_qlinear_cudnn on sm86 tests https://hud.pytorch.org/pytorch/pytorch/commit/cac7a22b92478d897488688010e562b7bd36b97f https://github.com/pytorch/pytorch/actions/runs/9470648757/job/26100448913. Probably a landrace, test ran on the PR and succeed ([comment](pytorch#128177 (comment)))
@pytorchmergebot rebase |
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
Rebase failed due to
Raised by https://github.com/pytorch/pytorch/actions/runs/9578696353 |
Similar in spirit to #125790, hopefully addresses failures seen for cuDNN 9.1 upgrade: ##128166
CC @nWEIdia @atalman
cc @csarofeen @ptrblck @xwang233 @jerryzh168 @jianyuh @raghuramank100 @jamesr66a @vkuzo @jgong5 @Xia-Weiwen @leslie-fang-intel @msaroufim