Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Tensor's __dlpack__ and __dlpack_device__ account for XLA. #128176

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make Tensor's __dlpack__ and __dlpack_device__ account for XLA. #128176

wants to merge 1 commit into from

Conversation

vanbasten23
Copy link
Contributor

@vanbasten23 vanbasten23 commented Jun 6, 2024 •
edited
Loading

Fixes #ISSUE_NUMBER

XLA tensor is a Tensor. This PR

  • makes __dlpack_device__ account for XLA device when XLA GPU is used.
  • makes __dlpack__ call the torch_xla version of to_dlpack.

A corresponding test is added in pytorch/xla#7213

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 6, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/128176

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 7c405b1 with merge base 6dfdce9 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@vanbasten23
Copy link
Contributor Author

cc @ysiraichi @JackCaoG

@vanbasten23 vanbasten23 mentioned this pull request Jun 6, 2024
Open
@vanbasten23 vanbasten23 mentioned this pull request Jun 10, 2024
Merged
@miladm
Copy link
Collaborator

miladm commented Jun 11, 2024

@emcastillo, @rgommers, @Mulberry are you the right person to review this PR? Appreciate the suggestion.

@colesbury colesbury added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jun 12, 2024
@vanbasten23
Copy link
Contributor Author

Hi @albanD @Skylion007 , could you help review this PR? Thanks!

@vanbasten23
Copy link
Contributor Author

Gentle ping @albanD @Skylion007

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albanD albanD Awaiting requested review from albanD

@Skylion007 Skylion007 Awaiting requested review from Skylion007

Assignees

@vanbasten23 vanbasten23

Labels
open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vanbasten23 @miladm @colesbury @pytorchbot