Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PT-D] Relaxed contract to allow Sequence[nn.Module] #127773

Closed
wants to merge 10 commits into from
+162 −74
Closed

[PT-D] Relaxed contract to allow Sequence[nn.Module] #127773

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
6494413
[PT-D] Relaxed `contract` to allow `Sequence[nn.Module]`
awgu Jun 3, 2024
e064321
Update on "[PT-D] Relaxed `contract` to allow `Sequence[nn.Module]`"
awgu Jun 3, 2024
38ec4ed
Update on "[PT-D] Relaxed `contract` to allow `Sequence[nn.Module]`"
awgu Jun 3, 2024
6f3d742
Update on "[PT-D] Relaxed `contract` to allow `Sequence[nn.Module]`"
awgu Jun 4, 2024
654a89d
Update on "[PT-D] Relaxed `contract` to allow `Sequence[nn.Module]`"
awgu Jun 4, 2024
4d08f3b
Update on "[PT-D] Relaxed `contract` to allow `Sequence[nn.Module]`"
awgu Jun 12, 2024
fd6f9bb
Update on "[PT-D] Relaxed `contract` to allow `Sequence[nn.Module]`"
awgu Jun 21, 2024
02b69a5
Update on "[PT-D] Relaxed `contract` to allow `Sequence[nn.Module]`"
awgu Jun 25, 2024
de90873
Update on "[PT-D] Relaxed `contract` to allow `Sequence[nn.Module]`"
awgu Jul 10, 2024
d1cd203
Update on "[PT-D] Relaxed `contract` to allow `Sequence[nn.Module]`"
awgu Jul 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update on "[PT-D] Relaxed contract to allow Sequence[nn.Module]" 
This PR relaxes `contract` to allow the 1st argument to be `Sequence[nn.Module]` instead of strictly `nn.Module`. This is required for the next PR, which allows `fully_shard` to take in `List[nn.Module]`.

cc mrshenli pritamdamania87 zhaojuanmao satgera gqchen aazzolini osalpekar jiayisuse H-Huang kwen2501 penguinwu fegin XilunWu wanchaol fduwjj wz337 tianyu-l wconstab yf225 chauhang d4l3k

[ghstack-poisoned]
  • Loading branch information
@awgu
awgu committed Jul 15, 2024
commit d1cd2039892c264684b5d33286b0b914a157a8c3

This merge commit was added into this branch cleanly.

There are no new changes to show, but you can still view the diff.