Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Updated torch.nn.Modules.set_submodules() #127714

Closed
wants to merge 11 commits into from
Closed

Feat: Updated torch.nn.Modules.set_submodules() #127714

wants to merge 11 commits into from

Conversation

Gunale0926
Copy link
Contributor 

modified:   torch/nn/modules/module.py

Implemented feature request by #127712.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 2, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/127714

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 24cc6f4 with merge base 795db80 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jun 2, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@Skylion007
Copy link
Collaborator

You need to sign the CLA. Also, there aren't any tests here.

@pytorch-bot pytorch-bot bot added the release notes: nn release notes category label Jun 2, 2024
@cpuhrsch cpuhrsch added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jun 3, 2024
mikaylagawarecki
mikaylagawarecki approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@mikaylagawarecki mikaylagawarecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@mikaylagawarecki mikaylagawarecki added the topic: new features topic category label Jun 13, 2024
@mikaylagawarecki
Copy link
Contributor

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 14, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 6 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@Gunale0926
Copy link
Contributor Author

Bug fixed.

@Gunale0926
Copy link
Contributor Author

I think some checks failed not because of my modification.

@mikaylagawarecki
Copy link
Contributor

@pytorchbot merge -r

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased main onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout main && git pull --rebase)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@mikaylagawarecki
Copy link
Contributor

@pytorchbot merge -r

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

Gunale0926 and others added 11 commits June 27, 2024 01:59
@Gunale0926 @pytorchmergebot
Feat: Updated torch.nn.Modules.set_submodules()
4775241 
	modified:   torch/nn/modules/module.py
@Gunale0926 @Skylion007 @pytorchmergebot
Update torch/nn/modules/module.py
18671bb 
Co-authored-by: Aaron Gokaslan <[email protected]>
@Gunale0926 @pytorchmergebot
Updated test and linted
0f580ae 
	modified:   test/test_nn.py
	modified:   torch/nn/modules/module.py
@Gunale0926 @pytorchmergebot
Fix: fixed type annotation
7e4ed11 
	modified:   torch/nn/modules/module.py
@Gunale0926 @pytorchmergebot
Lint: lint code
a9ea20b 
	modified:   torch/nn/modules/module.py
@Gunale0926 @pytorchmergebot
Update test
83ff732 
	modified:   test/test_nn.py
@Gunale0926 @pytorchmergebot
Update doc
53fb29f 
	modified:   torch/nn/modules/module.py
@Gunale0926 @pytorchmergebot
Fix test bug
2aedd88
@Gunale0926 @pytorchmergebot
Update test_nn.py
7079ae9
@Gunale0926 @pytorchmergebot
Update module.py
e47b33f 
Here must be strict torch.nn.Module type, which allows add submodule belonging to it.
@Gunale0926 @pytorchmergebot
Update Lint
24cc6f4
@pytorchmergebot
Copy link
Collaborator

Successfully rebased main onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout main && git pull --rebase)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikaylagawarecki mikaylagawarecki mikaylagawarecki approved these changes

@albanD albanD Awaiting requested review from albanD albanD is a code owner

@jbschlosser jbschlosser Awaiting requested review from jbschlosser jbschlosser is a code owner

@Skylion007 Skylion007 Awaiting requested review from Skylion007

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: nn release notes category topic: new features topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
torch.nn/optim
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Gunale0926 @Skylion007 @mikaylagawarecki @pytorchmergebot @cpuhrsch @pytorchbot