Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue 112919 #124746

Closed
wants to merge 2 commits into from
Closed

Fix issue 112919 #124746

wants to merge 2 commits into from

Conversation

melakueb
Copy link

@melakueb melakueb commented Apr 23, 2024 •
edited by pytorch-bot bot
Loading

This pull request modifies the export function in torch/_dynamo/eval_frame.py to handle the @torch._dynamo.assume_constant_result decorator. The changes allow for the correct handling of top-level annotated functions when using export with the assume_constant_result decorator.

Changes Made:
Added support for assume_constant_result decorator in the export function.

Additional Notes:
This modification was done for a course project as a computer science student. It's my first request :)

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Apr 23, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/124746

Note: Links to docs will display an error until the docs builds have been completed.

❌ 30 New Failures, 26 Unrelated Failures

As of commit ccf2091 with merge base 05db640 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Apr 23, 2024 •
edited
Loading

CLA Signed


The committers listed above are authorized under a signed CLA.

@soulitzer soulitzer added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Apr 24, 2024
angelayi
angelayi reviewed Apr 24, 2024
View reviewed changes
Copy link
Contributor

@angelayi angelayi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks for working on this! Could you please add a test to test/dynamo/test_export.py to show that your fix works?

@github-actions GitHub Actions
Copy link

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the Stale label Jun 23, 2024
@github-actions github-actions bot closed this Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angelayi angelayi angelayi left review comments

@ydwu4 ydwu4 Awaiting requested review from ydwu4

Assignees
No one assigned
Labels
module: dynamo open source Stale triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@melakueb @angelayi @soulitzer @pytorchbot