-
Notifications
You must be signed in to change notification settings - Fork 21.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(quantization): Enable PT2E symmetric dynamic quantization #124615
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/124615
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 1 Unrelated FailureAs of commit 87184e4 with merge base 92be340 (): NEW FAILURES - The following jobs have failed:
UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@kimishpatel, would you please review this PR? |
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Hi, @colesbury @kimishpatel are we okay to merge that PR? |
@pytorchbot merge -i |
Pull workflow has not been scheduled for the PR yet. It could be because author doesn't have permissions to run those or skip-checks keywords were added to PR/commits, aborting merge. Please get/give approval for the workflows and/or remove skip ci decorators before next merge attempt. If you think this is a mistake, please contact PyTorch Dev Infra. |
can you rebase? I am trying to see if I can trigger ci |
7285c1e
to
b803262
Compare
Rebased :) |
@pytorchbot merge |
Pull workflow has not been scheduled for the PR yet. It could be because author doesn't have permissions to run those or skip-checks keywords were added to PR/commits, aborting merge. Please get/give approval for the workflows and/or remove skip ci decorators before next merge attempt. If you think this is a mistake, please contact PyTorch Dev Infra. |
@malfet can you merge this one? Not sure what i am doing wrong |
@kimishpatel enabled the workflow, let's see if it's green |
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 mandatory check(s) failed. The first few are: Dig deeper by viewing the failures on hud |
hey @malfet, I have update the commit to fix the linting issue. sorry about that. |
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 jobs have failed, first few of them are: trunk / macos-py3-arm64 / test (default, 2, 3, macos-m1-stable) Details for Dev Infra teamRaised by workflow job |
in `_find_choose_qparams_node` function compare the current node if it is affine or symmetric
f59441c
to
87184e4
Compare
@pkluska please let me know whether or not your PR is ready for review, as you keep pushing new changes to it. |
@pytorchbot merge -i |
Merge startedYour change will be merged while ignoring the following 3 checks: pull / linux-jammy-py3-clang12-executorch / test (executorch, 1, 1, linux.2xlarge), pull / linux-focal-cuda12.1-py3.10-gcc9-experimental-split-build / test (default, 3, 5, linux.4xlarge.nvidia.gpu, unstable), trunk / macos-py3-arm64-mps / test (mps, 1, 1, macos-m1-13) Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
in
_find_choose_qparams_node
function comparethe current node if it is affine or symmetric