Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(quantization): Enable PT2E symmetric dynamic quantization #124615

Closed
wants to merge 2 commits into from

Conversation

pkluska
Copy link
Contributor

@pkluska pkluska commented Apr 22, 2024

in _find_choose_qparams_node function compare
the current node if it is affine or symmetric

Copy link

pytorch-bot bot commented Apr 22, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/124615

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Unrelated Failure

As of commit 87184e4 with merge base 92be340 (image):

NEW FAILURES - The following jobs have failed:

UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@colesbury colesbury added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Apr 22, 2024
@colesbury
Copy link
Member

@kimishpatel, would you please review this PR?

Copy link

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the Stale label Jun 22, 2024
@pkluska
Copy link
Contributor Author

pkluska commented Jun 24, 2024

Hi, @colesbury @kimishpatel are we okay to merge that PR?

@kimishpatel
Copy link
Contributor

@pytorchbot merge -i

Copy link

pytorch-bot bot commented Jun 24, 2024

Pull workflow has not been scheduled for the PR yet. It could be because author doesn't have permissions to run those or skip-checks keywords were added to PR/commits, aborting merge. Please get/give approval for the workflows and/or remove skip ci decorators before next merge attempt. If you think this is a mistake, please contact PyTorch Dev Infra.

@kimishpatel
Copy link
Contributor

can you rebase? I am trying to see if I can trigger ci

@pkluska
Copy link
Contributor Author

pkluska commented Jun 25, 2024

can you rebase? I am trying to see if I can trigger ci

Rebased :)

@kimishpatel
Copy link
Contributor

@pytorchbot merge

Copy link

pytorch-bot bot commented Jun 26, 2024

Pull workflow has not been scheduled for the PR yet. It could be because author doesn't have permissions to run those or skip-checks keywords were added to PR/commits, aborting merge. Please get/give approval for the workflows and/or remove skip ci decorators before next merge attempt. If you think this is a mistake, please contact PyTorch Dev Infra.

@kimishpatel
Copy link
Contributor

@malfet can you merge this one? Not sure what i am doing wrong

@malfet
Copy link
Contributor

malfet commented Jun 26, 2024

@kimishpatel enabled the workflow, let's see if it's green

@malfet
Copy link
Contributor

malfet commented Jun 26, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 26, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@pkluska
Copy link
Contributor Author

pkluska commented Jun 26, 2024

hey @malfet, I have update the commit to fix the linting issue. sorry about that.

@malfet
Copy link
Contributor

malfet commented Jun 26, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / macos-py3-arm64 / test (default, 2, 3, macos-m1-stable)

Details for Dev Infra team Raised by workflow job

in `_find_choose_qparams_node` function compare
the current node if it is affine or symmetric
@malfet
Copy link
Contributor

malfet commented Jun 26, 2024

@pkluska please let me know whether or not your PR is ready for review, as you keep pushing new changes to it.

@pkluska
Copy link
Contributor Author

pkluska commented Jun 26, 2024

@pkluska please let me know whether or not your PR is ready for review, as you keep pushing new changes to it.

@malfet I rebased it, as since yesterday there were additional pushes to main branch. It seems that not related checks were failing. Otherwise, it is ready

@malfet
Copy link
Contributor

malfet commented Jun 26, 2024

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 3 checks: pull / linux-jammy-py3-clang12-executorch / test (executorch, 1, 1, linux.2xlarge), pull / linux-focal-cuda12.1-py3.10-gcc9-experimental-split-build / test (default, 3, 5, linux.4xlarge.nvidia.gpu, unstable), trunk / macos-py3-arm64-mps / test (mps, 1, 1, macos-m1-13)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: AO frontend release notes: quantization release notes category Stale triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants