-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ROCm] Optionally use hipblaslt #120551
base: main
Are you sure you want to change the base?
[ROCm] Optionally use hipblaslt #120551
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/120551
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 3 New Failures, 2 Unrelated FailuresAs of commit 8edc7b9 with merge base bab4b5a ( NEW FAILURES - The following jobs have failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@xw285cornell would appreciate your review of this. I'm assuming this PR will break your internal build? |
The hipblaslt package is not available on Fedora. Instead of requiring the package, make it optional. If it is found, define the preprocessor variable HIPBLASLT Convert the checks for ROCM_VERSION >= 507000 to HIPBLASLT checks Signed-off-by: Tom Rix <[email protected]>
2c029b1
to
8edc7b9
Compare
Update for a couple more hipblaslt usages that were added in main this week. |
This PR looks pretty straight forward and using a variable instead of "magic" version numbers seem to be much cleaner. It would be nice if this PR wouldn't linger around much longer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest USE_HIPBLASLT
instead of HIPBLASLT
as name for define
considering that the basis issue of this pr #119081 is now correctly recognized as a bug i think it would be good to not leave this lingering much longer. |
Sorry just see this. Thanks @jeffdaily for pinging, this will break our internal codebase but it should be an easy fix. I'm not objecting the idea, if you can ping me before this PR lands, I can put a fix to our internal system easily. |
@trixirt Please resolve conflicts and I'll request an upstream maintainer to approve. |
@trixirt Please do consider this renaming to be aligned with current naming |
I am working on this. Its a bit involved and in a parallel track i trying to get hipblastlt to build on Fedora. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I have submitted the hipBLASLt package for Fedora here A prelim refactoring of the above change is here refactored for 2.4 Fedora/My preference is to use the package once it is available. |
The hipblaslt package is not available on Fedora.
Instead of requiring the package, make it optional. If it is found, define the preprocessor variable HIPBLASLT Convert the checks for ROCM_VERSION >= 50700 to HIPBLASLT checks
Fixes #119081
cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang