-
Notifications
You must be signed in to change notification settings - Fork 21.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[POC][pytree] test flattening dict in sorted order #115014
Draft
XuehaiPan
wants to merge
10
commits into
pytorch:main
Choose a base branch
from
XuehaiPan:sorted-dict-order
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+193
−103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
281b1fa
to
4d8420e
Compare
22c1260
to
91a89ae
Compare
53de390
to
26c63f9
Compare
6d6560a
to
a02cadc
Compare
e936862
to
063d8c0
Compare
3649a63
to
8297134
Compare
e32d37f
to
ec5b089
Compare
37fb23c
to
cfb966d
Compare
cfb966d
to
10b67f1
Compare
de3034c
to
30efb8b
Compare
b0689a3
to
067170e
Compare
067170e
to
cece948
Compare
cece948
to
838d979
Compare
This reverts commit b60fbf8.
838d979
to
ba69b86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ciflow/inductor
ciflow/trunk
Trigger trunk jobs on your pull request
keep-going
Don't stop on first failure, keep running tests until the end
module: dynamo
module: inductor
open source
release notes: fx
release notes category
release notes: quantization
release notes category
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test if we can flatten the dictionary in a deterministic sorted order.
Original PR:
dict
in sorted key ordering #114947cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @aakhundov @ColinPeppler