Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update NeptuneLogger docstring and example script #2886

Merged
merged 50 commits into from
Mar 14, 2023
Merged

Update NeptuneLogger docstring and example script #2886

merged 50 commits into from
Mar 14, 2023

Conversation

normandy7
Copy link
Contributor

Description:

  • Correct Args and code samples in the NeptuneLogger docstring
  • Update MNIST example script

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

jakubczakon and others added 30 commits January 26, 2020 18:40
@jakubczakon
added output handlers, model checkpoint handler, added mnist example,…
0760506 
… added initial tests file
@jakubczakon
added exp link to examples, added tests
ea65a1a
@jakubczakon
added neptune do docs
9372b8b
@jakubczakon
Merge branch 'master' into master
f3d81c5
@jakubczakon
fixed test
c3d9556
@jakubczakon
Merge branch 'master' of https://github.com/neptune-ai/ignite
bfff60c
@jakubczakon
fixed imports
741d3d7
@jakubczakon
added neptune-client to test dependencies
0d3b1f5
@jakubczakon
fixed missing package message
7f00f6a
@jakubczakon
Merge branch 'master' into master
cc5ca70
@jakubczakon
dropped model checkpoing handler
cc450b8
@jakubczakon
updated experiment link
b0bf959
@jakubczakon
dropped __futures__ print_function
73d4001
@jakubczakon
updated fork
e47a994
@jakubczakon
added NeptuneSaver and tests
d69068c
@actions-user
autopep8 fix
1cdfd83
@jakubczakon
updated token to anonymous user neptuner
39e2c66
@jakubczakon
Merge branch 'master' of https://github.com/neptune-ai/ignite
de7000f
@jakubczakon
updated experiment link
5b345a6
@jakubczakon
Merge branch 'master' into master
b2e0901
@jakubczakon
updated token to 'ANONYMOUS'
7ddf4d3
@jakubczakon
Merge branch 'master' of https://github.com/neptune-ai/ignite
6b13741
@jakubczakon
Merge branch 'master' into master
a0a43d9
@jakubczakon
updated examples, fixed tests
05d3c6f
@actions-user
autopep8 fix
4022987
@jakubczakon
fixed serializable test
d2a8b23
@jakubczakon
Merge branch 'master' of https://github.com/neptune-ai/ignite
fb59d0c
@jakubczakon
fixed serializable model test
2a79216
@jakubczakon
local
c2bc4c5
@jakubczakon
added __getattr__, fixed experiment_name, fixed api_token=None
d363722
jakubczakon and others added 18 commits April 21, 2020 20:12
@jakubczakon
merged conflicts
3ebeffd
@actions-user
autopep8 fix
e4a99f7
@jakubczakon
added self.experiment back
ae1669d
@jakubczakon
Merge branch 'master' of https://github.com/neptune-ai/ignite
48b449e
@twolodzko
Merge remote-tracking branch 'upstream/master' into update-neptune-in…
ae6439c 
…tegration
@twolodzko
Fix after merge
627e78e
@twolodzko
Update Neptune integration for compatibility with recent changes in N…
06fa414 
…eptune client
@twolodzko
Merge branch 'pytorch:master' into update-neptune-integration
4eda471
@twolodzko
Track the version of Ignite in Neptune
1f22ab9
@twolodzko
Ignore the future deprecation warnings when importing neptune.new
185acda
@twolodzko @github-actions
autopep8 fix
e3a3ea3
@twolodzko
Merge branch 'master' into update-neptune-integration
40a72a4
@twolodzko
Make INTEGRATION_VERSION_KEY private
2dddf95
@twolodzko
Add type annotations
15feb59
@twolodzko
Add type annotation to kwargs
94aaeb5
@twolodzko
Use >= in requirements
494826f
@twolodzko
Fix failing test
a432aed
@normandy7
update NeptuneLogger docstring and MNIST example
a1576c9
@github-actions github-actions bot added examples Examples module: contrib Contrib module labels Mar 10, 2023
vfdev-5
vfdev-5 approved these changes Mar 12, 2023
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @normandy7 , LGTM

ignite/contrib/handlers/neptune_logger.py Outdated Show resolved Hide resolved
@vfdev-5 vfdev-5 marked this pull request as ready for review March 12, 2023 22:31
@vfdev-5 vfdev-5 enabled auto-merge (squash) March 14, 2023 08:00
@vfdev-5 vfdev-5 disabled auto-merge March 14, 2023 08:40
@vfdev-5 vfdev-5 merged commit 15dc9bb into pytorch:master Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Assignees
No one assigned
Labels
examples Examples module: contrib Contrib module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@normandy7 @vfdev-5 @jakubczakon @twolodzko