Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with Horovod cpu tests #2798

Merged
merged 4 commits into from
Dec 9, 2022
Merged

Conversation

sadra-barikbin
Copy link
Collaborator

@sadra-barikbin sadra-barikbin commented Dec 9, 2022

Description:

  • Fixed issue with Horovod cpu tests

Context:
Since #2790 Horovod cpu job skips horovod test:

tests/ignite/metrics/test_psnr.py::test_distrib_input_float[horovod] SKIPPED (Skip if no Horovod dist support) [ 86%]

https://github.com/pytorch/ignite/actions/runs/3654919549/jobs/6175755766#step:9:1770

@github-actions github-actions bot added the ci CI label Dec 9, 2022
@sadra-barikbin sadra-barikbin force-pushed the add-check-in-hvd-workflow branch 2 times, most recently from 27620c2 to 4bd883e Compare December 9, 2022 14:13
@vfdev-5
Copy link
Collaborator

vfdev-5 commented Dec 9, 2022

@sadra-barikbin Can you update PR's title and description

@vfdev-5 vfdev-5 changed the title Add Horovod existence check to its workflow Fixed issue with Horovod cpu tests Dec 9, 2022
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vfdev-5 vfdev-5 merged commit e8e42c2 into master Dec 9, 2022
@sadra-barikbin sadra-barikbin deleted the add-check-in-hvd-workflow branch December 10, 2022 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants