Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update fractional bias and test_geometric_mae to generate data with different rank #2660

Merged
merged 5 commits into from
Aug 31, 2022
Merged

Update fractional bias and test_geometric_mae to generate data with different rank #2660

merged 5 commits into from
Aug 31, 2022

Conversation

puhuk
Copy link
Contributor

@puhuk puhuk commented Aug 20, 2022

Description: Update fractional bias and test_geometric_mae

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@puhuk
Update metrics to work in ddp config
54daa6b 
Update `fractional bias` and `test_geometric_mae`
@vfdev-5
Copy link
Collaborator

vfdev-5 commented Aug 20, 2022

@puhuk PRs title is incorrect and doesn't reflect the content. Please fix it

@puhuk puhuk changed the title Update metrics to work in ddp config Update fractional bias and test_geometric_mae to generate data with different rank Aug 20, 2022
@vfdev-5
Copy link
Collaborator

vfdev-5 commented Aug 23, 2022

@puhuk CI is failing, please update this PR

@sadra-barikbin
Copy link
Collaborator

@vfdev-5 , test_geometric_mean_relative_absolute_error.py::test_integration is failing without any change related to it. Is this a rare case?
image

@vfdev-5
Copy link
Collaborator

vfdev-5 commented Aug 26, 2022 •
edited
Loading

@sadra-barikbin seems like failures are related to this PR as master branch and other PR are not failing. We can check test_geometric_mean_relative_absolute_error.py::test_integration on master with different seed to see if it is related to randomness seed.

@vfdev-5
Copy link
Collaborator

vfdev-5 commented Aug 30, 2022

@puhuk what do you suggest to fix the tests and make this PR merged ?

@puhuk
Copy link
Contributor Author

puhuk commented Aug 31, 2022

@vfdev-5 as @sadra-barikbin mentioned, I change the random seed 12 to 11

vfdev-5
vfdev-5 approved these changes Aug 31, 2022
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @puhuk

@vfdev-5 vfdev-5 enabled auto-merge (squash) August 31, 2022 05:04
@vfdev-5 vfdev-5 merged commit 1a8fed8 into pytorch:master Aug 31, 2022
@puhuk puhuk deleted the fractional_bias_geometric_mae branch September 10, 2022 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sadra-barikbin sadra-barikbin sadra-barikbin approved these changes

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@puhuk @vfdev-5 @sadra-barikbin