Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GPU tests because of missing .cpu() #2506

Merged
merged 4 commits into from
Mar 8, 2022

Conversation

sdesrozis
Copy link
Contributor

Related to #2490

Description:

Missing cpu() to use numpy() on Tensors

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@github-actions github-actions bot added the module: contrib Contrib module label Mar 8, 2022
@vfdev-5
Copy link
Collaborator

vfdev-5 commented Mar 8, 2022

@sdesrozis can you push the branch to origin and thus run GPU tests. It wont run on your fork

@sdesrozis
Copy link
Contributor Author

You mean I create a branch in the ignite repo and I push the fix inside ? Or maybe there is a smarter way to do that using a relevant git command line ?

@vfdev-5
Copy link
Collaborator

vfdev-5 commented Mar 8, 2022

yes, just do the following, assuming the origin points to https://github.com/pytorch/ignite

git push origin fix_gpu_precision_recall_curve

@sdesrozis
Copy link
Contributor Author

It seems I can't rerun workflow from CircleCI...

@vfdev-5
Copy link
Collaborator

vfdev-5 commented Mar 8, 2022

Let's skip circle ci, if Run unit tests on GPUs / gpu-tests (push) passes we can merge this PR.

@vfdev-5
Copy link
Collaborator

vfdev-5 commented Mar 8, 2022

@sdesrozis tests are stuck on tests/ignite/contrib/metrics/test_precision_recall_curve.py::test_distrib_nccl_gpu
I'll rerun it to see if it is real

@vfdev-5
Copy link
Collaborator

vfdev-5 commented Mar 8, 2022

Looks like real. I'll cancel the job and check later what happens.

@vfdev-5 vfdev-5 merged commit 90d79aa into pytorch:master Mar 8, 2022
@vfdev-5 vfdev-5 deleted the fix_gpu_precision_recall_curve branch March 8, 2022 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: contrib Contrib module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants