Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip ci] Add doctest for MetricsLambda #2352

Merged
merged 2 commits into from
Dec 12, 2021

Conversation

sdesrozis
Copy link
Contributor

@sdesrozis sdesrozis commented Dec 10, 2021

Addresses #2265

Description: Add doctest for MetricsLambda

@ydcjeff

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@github-actions github-actions bot added the module: metrics Metrics module label Dec 10, 2021
@vfdev-5
Copy link
Collaborator

vfdev-5 commented Dec 10, 2021

@sdesrozis seems like you have to put [skip ci] to the commit and not the PR title to skip the CI.
And bravo for sending 7 PRs on docstrings 💪

@sdesrozis
Copy link
Contributor Author

sdesrozis commented Dec 10, 2021

@sdesrozis seems like you have to put [skip ci] to the commit and not the PR title to skip the CI.

Ah ah...

And bravo for sending 7 PRs on docstrings 💪

Yep, I think it's finished (still merge to do) for metrics.

Now let's do the same for param schedulers.

@sdesrozis sdesrozis merged commit f7bba0c into pytorch:master Dec 12, 2021
@sdesrozis sdesrozis deleted the doctest_lambdametric branch December 12, 2021 14:16
@sdesrozis sdesrozis mentioned this pull request Dec 12, 2021
51 tasks
Ishan-Kumar2 pushed a commit to Ishan-Kumar2/ignite that referenced this pull request Dec 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: metrics Metrics module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants