Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Captured CI warnings #2232

Merged
merged 2 commits into from
Oct 2, 2021
Merged

Captured CI warnings #2232

merged 2 commits into from
Oct 2, 2021

Conversation

KickItLikeShika
Copy link
Contributor

Captured the raised warnings by LRFinder here https://github.com/pytorch/ignite/runs/3737999174#step:15:1393
and https://github.com/pytorch/ignite/runs/3737999174#step:15:1403

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

Copy link
Contributor

@sdesrozis sdesrozis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KickItLikeShika Thanks ! LGTM :) Let's see if CI works.

@vfdev-5 vfdev-5 merged commit 1d75cd8 into pytorch:master Oct 2, 2021
@vfdev-5
Copy link
Collaborator

vfdev-5 commented Oct 2, 2021

@KickItLikeShika Thanks for the PR, can we also get rid of this warning:

tests/ignite/handlers/test_time_profilers.py:9
  /home/runner/work/ignite/ignite/tests/ignite/handlers/test_time_profilers.py:9: DeprecationWarning: /home/runner/work/ignite/ignite/ignite/contrib/handlers/time_profilers.py has been moved to /ignite/handlers/time_profilers.py and will be removed in version 0.6.0.
   Please refer to the documentation for more details.
    from ignite.contrib.handlers.time_profilers import BasicTimeProfiler, HandlersTimeProfiler

@KickItLikeShika KickItLikeShika deleted the fix-warnings branch October 3, 2021 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants