Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed num of warnings assertion from lrfinder tests #2231

Merged
merged 2 commits into from
Sep 28, 2021
Merged

Removed num of warnings assertion from lrfinder tests #2231

merged 2 commits into from
Sep 28, 2021

Conversation

KickItLikeShika
Copy link
Contributor

Fixes #2141, #2150, #2156

Remove the number of warnings assertion from lrfinder tests.

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

vfdev-5
vfdev-5 approved these changes Sep 28, 2021
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @KickItLikeShika !

@vfdev-5 vfdev-5 enabled auto-merge (squash) September 28, 2021 21:40
@vfdev-5 vfdev-5 merged commit e30dbad into pytorch:master Sep 28, 2021
@KickItLikeShika KickItLikeShika deleted the remove-commnted-lrfinder branch September 29, 2021 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scheduled workflow failed
2 participants
@KickItLikeShika @vfdev-5