Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix expand hostlist for SLURM #2204

Merged
merged 4 commits into from
Sep 17, 2021
Merged

Fix expand hostlist for SLURM #2204

merged 4 commits into from
Sep 17, 2021

Conversation

sdesrozis
Copy link
Contributor

@sdesrozis sdesrozis commented Sep 17, 2021 •
edited
Loading

Fixes #2203

Description:

See #2048 (comment)

Fix _expand_hostlist

_expand_hostlist('c1001a-s[11,17]')
> 
["c1001a-s11", "c1001a-s17"]

matches

scontrol show hostnames 'c1001a-s[11,17]'
>
c1001a-s11
c1001a-s17

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@github-actions github-actions bot added the module: distributed Distributed module label Sep 17, 2021
vfdev-5
vfdev-5 approved these changes Sep 17, 2021
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sdesrozis ! LGTM

@vfdev-5 vfdev-5 merged commit 554fd80 into pytorch:master Sep 17, 2021
@vfdev-5 vfdev-5 deleted the fix_expand_hostlist branch September 17, 2021 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Assignees
No one assigned
Labels
module: distributed Distributed module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug with _expand_nodelist
2 participants
@sdesrozis @vfdev-5