Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved Checkpoint to use score_name as metric's key #2146

Merged
merged 10 commits into from
Aug 10, 2021
Merged

Improved Checkpoint to use score_name as metric's key #2146

merged 10 commits into from
Aug 10, 2021

Conversation

KickItLikeShika
Copy link
Contributor

Fixes #2129

Improved Checkpoint to be able to fetch score_function as Checkpoint.get_default_score_fn("accuracy") by default if score_name is set, and added a test to cover that.

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@github-actions github-actions bot added the module: handlers Core Handlers module label Aug 9, 2021
vfdev-5
vfdev-5 approved these changes Aug 10, 2021
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @KickItLikeShika

@vfdev-5 vfdev-5 enabled auto-merge (squash) August 10, 2021 13:02
@vfdev-5 vfdev-5 merged commit 81a3fbd into pytorch:master Aug 10, 2021
@KickItLikeShika KickItLikeShika deleted the improve-checkpoint branch August 10, 2021 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Assignees
No one assigned
Labels
module: handlers Core Handlers module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use score_name as metric's key in Checkpoint
2 participants
@KickItLikeShika @vfdev-5