Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Mean Error for DDP #2083

Merged
merged 4 commits into from
Jun 26, 2021

Conversation

KickItLikeShika
Copy link
Contributor

Fixes part of #1284

Made mean error metric compatible with DDP and add the necessary tests. And added an integration tests.

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@github-actions github-actions bot added the module: contrib Contrib module label Jun 26, 2021
@vfdev-5
Copy link
Collaborator

vfdev-5 commented Jun 26, 2021

@KickItLikeShika thanks for the PR !

@vfdev-5 vfdev-5 merged commit a1c061b into pytorch:master Jun 26, 2021
@KickItLikeShika KickItLikeShika deleted the improve-mean-error-ddp branch June 26, 2021 22:13
@vfdev-5
Copy link
Collaborator

vfdev-5 commented Jun 28, 2021

@KickItLikeShika seems like GPU tests wont pass: https://app.circleci.com/pipelines/github/pytorch/ignite/1993/workflows/4c558b7a-dc4d-48fd-bc89-e8fda3404d23/jobs/6059
(this is the PR that will fix the issue with FID/IS that currently is failing and stopping other metric tests)

@KickItLikeShika
Copy link
Contributor Author

Thanks for reporting that, unfortunately after trying to avoid sending follow-up PRs, we need to send another one, and add tolerence for distributed integration test, I will send the PR in minutes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: contrib Contrib module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants