Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the node zero rank zero download constraint for examples #1924

Merged
merged 6 commits into from
Apr 13, 2021
Merged

Fix the node zero rank zero download constraint for examples #1924

merged 6 commits into from
Apr 13, 2021

Conversation

Moh-Yakoub
Copy link
Contributor

Fixes #1922

Description:

As described in the issue: Datasets are downloading only on node 0, rank 0 in Ignite examples. idist.get_rank() should be idist.get_local_rank()

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@github-actions github-actions bot added the examples Examples label Apr 10, 2021
vfdev-5
vfdev-5 reviewed Apr 13, 2021
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Moh-Yakoub !

@vfdev-5 vfdev-5 enabled auto-merge (squash) April 13, 2021 21:39
@vfdev-5 vfdev-5 merged commit e6b2c32 into pytorch:master Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Assignees
No one assigned
Labels
examples Examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Datasets are downloading only on node 0, rank 0 in Ignite examples.
2 participants
@Moh-Yakoub @vfdev-5