Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: up pytorch to 1.8.1 #1878

Merged
merged 1 commit into from
Mar 26, 2021
Merged

ci: up pytorch to 1.8.1 #1878

merged 1 commit into from
Mar 26, 2021

Conversation

ydcjeff
Copy link
Contributor

@ydcjeff ydcjeff commented Mar 26, 2021

fixes #1874

Description:

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@github-actions github-actions bot added the ci CI label Mar 26, 2021
@vfdev-5
Copy link
Collaborator

vfdev-5 commented Mar 26, 2021

@ydcjeff thanks for the PR! I think it is ready to merge as it is.

However, I understand now that we are still missing the correct way to trigger docker build. I think trigger it on .circleci/config.yml change would be expensive. We can think to do the following in another PR. Basically, try to make use of yml file import:

  • create .circleci/docker-config.yml with
  build_docker_image_pytorch_version:
    type: string
    default: "1.8.1-cuda11.1-cudnn8"
  build_docker_image_hvd_version:
    type: string
    default: "v0.21.3"
  build_docker_image_msdp_version:
    type: string
    default: "v0.3.10"
  • import it inside .circleci/config.yml :
  • add .circleci/docker-config.yml to

on:
pull_request:
paths:
- docker/**
- ".github/workflows/docker-build.yml"

and

paths:
- docker/**
- ".github/workflows/docker-publish.yml"

Probably, we also have to modify

export PTH_VERSION=`python -c "import yaml; f=open('.circleci/config.yml'); d=yaml.safe_load(f); print(d['parameters']['build_docker_image_pytorch_version']['default'])"`
export HVD_VERSION=`python -c "import yaml; f=open('.circleci/config.yml'); d=yaml.safe_load(f); print(d['parameters']['build_docker_image_hvd_version']['default'])"`

Let's also update MSDP to v0.3.13

Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade CI to pth 1.8.1
2 participants