Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: skip test_create_supervised_training_scalar_assignment if torch < 1.6.0 #1877

Merged
merged 3 commits into from
Mar 26, 2021
Merged

fix: skip test_create_supervised_training_scalar_assignment if torch < 1.6.0 #1877

merged 3 commits into from
Mar 26, 2021

Conversation

ydcjeff
Copy link
Contributor

@ydcjeff ydcjeff commented Mar 26, 2021

fixes #1875
fixes #1871

Description:

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@github-actions github-actions bot added the ci CI label Mar 26, 2021
@ydcjeff
Copy link
Contributor Author

ydcjeff commented Mar 26, 2021

See the checks of first commit : https://github.com/pytorch/ignite/actions/runs/689224431

vfdev-5
vfdev-5 approved these changes Mar 26, 2021
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks a lot @ydcjeff !

@vfdev-5 vfdev-5 merged commit ff3384b into pytorch:master Mar 26, 2021
@ydcjeff ydcjeff deleted the patch-1 branch March 26, 2021 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Assignees
No one assigned
Labels
ci CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scheduled workflow failed Scheduled workflow failed
2 participants
@ydcjeff @vfdev-5