Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve MAE metric for DDP #1850

Merged
merged 6 commits into from
Mar 22, 2021
Merged

Improve MAE metric for DDP #1850

merged 6 commits into from
Mar 22, 2021

Conversation

KickItLikeShika
Copy link
Contributor

Improving MaximumAbsoluteError implementation to be compatible with DDP and add the necessary tests.

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@github-actions github-actions bot added the module: contrib Contrib module label Mar 22, 2021
sdesrozis
sdesrozis approved these changes Mar 22, 2021
View reviewed changes
Copy link
Contributor

@sdesrozis sdesrozis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KickItLikeShika Thank you ! LGTM

@vfdev-5 vfdev-5 merged commit b884b96 into pytorch:master Mar 22, 2021
@KickItLikeShika KickItLikeShika deleted the improve-max-abs-error branch March 23, 2021 08:25
@vfdev-5 vfdev-5 added this to In progress in 0.4.5 via automation May 31, 2021
@vfdev-5 vfdev-5 moved this from In progress to Done in 0.4.5 May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdesrozis sdesrozis sdesrozis approved these changes

Assignees
No one assigned
Labels
module: contrib Contrib module
Projects
No open projects
0.4.5
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@KickItLikeShika @sdesrozis @vfdev-5