Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run pip as module for all os #1847

Merged
merged 3 commits into from
Mar 22, 2021
Merged

Conversation

ydcjeff
Copy link
Contributor

@ydcjeff ydcjeff commented Mar 22, 2021

Description:
Fixes fail to get python wheel cache in ubuntu CI.
ubuntu has been updated to 20.04, we can just use pip
For to work with cross platform, we need to with python3 -m as macos still has python2.7

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@github-actions github-actions bot added the ci CI label Mar 22, 2021
@trsvchn
Copy link
Collaborator

trsvchn commented Mar 22, 2021

@ydcjeff Thank you for your PR. I am just wondering about windows, since I was facing this kind of issue when running python3 -m venv venv on windows-latest:

/c/hostedtoolcache/windows/Python/3.7.9/x64/python3
Error: [WinError 2] The system cannot find the file specified

See: msys2/MINGW-packages#5001 (comment)

So, I am not sure about pip, maybe it was venv issue or smth, did you try it on windows-latest?

@ydcjeff
Copy link
Contributor Author

ydcjeff commented Mar 22, 2021

If use with setup-python, python alone is enough and it works

Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ydcjeff

@vfdev-5 vfdev-5 merged commit cf2ce7a into pytorch:master Mar 22, 2021
@ydcjeff ydcjeff deleted the ci/pip-cache branch March 22, 2021 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants