Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cov: add tests in {events,deterministic}.py #1812

Merged
merged 8 commits into from
Mar 19, 2021
Merged

cov: add tests in {events,deterministic}.py #1812

merged 8 commits into from
Mar 19, 2021

Conversation

ydcjeff
Copy link
Contributor

@ydcjeff ydcjeff commented Mar 17, 2021

Part of #1790

Description: Add tests in events.py

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@github-actions github-actions bot added the module: engine Engine module label Mar 17, 2021
@ydcjeff ydcjeff changed the title cov: add tests in events.py cov: add tests in events/distributed.py Mar 17, 2021
@ydcjeff ydcjeff changed the title cov: add tests in events/distributed.py cov: add tests in {events,deterministic}.py Mar 17, 2021
trsvchn
trsvchn approved these changes Mar 18, 2021
View reviewed changes
Copy link
Collaborator

@trsvchn trsvchn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @ydcjeff !

sdesrozis
sdesrozis approved these changes Mar 19, 2021
View reviewed changes
Copy link
Contributor

@sdesrozis sdesrozis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ydcjeff Thank you !

@sdesrozis sdesrozis merged commit 793b254 into pytorch:master Mar 19, 2021
@ydcjeff ydcjeff deleted the event-cov branch March 19, 2021 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdesrozis sdesrozis sdesrozis approved these changes

@trsvchn trsvchn trsvchn approved these changes

Assignees
No one assigned
Labels
module: engine Engine module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ydcjeff @sdesrozis @trsvchn @vfdev-5