Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cov: add tests for ignite.contrib.metrics #1809

Merged
merged 14 commits into from
Mar 22, 2021
Merged

cov: add tests for ignite.contrib.metrics #1809

merged 14 commits into from
Mar 22, 2021

Conversation

ydcjeff
Copy link
Contributor

@ydcjeff ydcjeff commented Mar 17, 2021 •
edited
Loading

Part of #1790

Description: Add tests for ignite.contrib.metrics

Put shape checking to the end

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@ydcjeff ydcjeff changed the title cov: add tests for ignite.contrib.metrics no regression cov: add tests for ignite.contrib.metrics Mar 17, 2021
@github-actions github-actions bot added the module: contrib Contrib module label Mar 17, 2021
sdesrozis
sdesrozis approved these changes Mar 22, 2021
View reviewed changes
Copy link
Contributor

@sdesrozis sdesrozis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ydcjeff Thank you ! LGTM

@sdesrozis sdesrozis merged commit 1eaf7ae into pytorch:master Mar 22, 2021
@ydcjeff ydcjeff deleted the contrib-metrics-cov branch March 22, 2021 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdesrozis sdesrozis sdesrozis approved these changes

Assignees
No one assigned
Labels
module: contrib Contrib module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ydcjeff @sdesrozis