Fix sanity check due to new mistune version #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Deploy Preview for pytorch-hub-preview failed. 🔨 Explore the source changes: a1549ec 🔍 Inspect the deploy log: https://app.netlify.com/sites/pytorch-hub-preview/deploys/61b86ab79b17470007772c6d |
fmassa
approved these changes
Dec 14, 2021
|
Looks like CircleCI is flaky this morning. I merged this PR's branch in the unrelated #247, and the Sanity checks pass , so we can merge it safely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mistune 2.0 is out with some breaking changes, it doesn't parse the markdown files the same way it used to, leading to failures like in https://app.circleci.com/pipelines/github/pytorch/hub/1491/workflows/32ba622d-23bd-49e3-8a9c-9e3a5aa5532a/jobs/1926
This PR fixes our script to rely on mistune's latest version.