Move torch version check to test json and update repo fields #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wconstab
force-pushed
the
wconstab/fields
branch
from
86d1d95
to
c4cc4bf
Compare
malfet
reviewed
Sep 11, 2020
|
@malfet Yea, i was going back and forth about how to do this but I like your way. |
wconstab
force-pushed
the
wconstab/fields
branch
from
212cf4e
to
bb90f48
Compare
- change incorrect/confusing 'pytorch_commit_*' vars to git_* vars
since the vars are used in repos such as benchmark
- record torch pkg versions explicitly regardless of repo used
for benchmark runs
wconstab
force-pushed
the
wconstab/fields
branch
from
bb90f48
to
93060be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since the vars are used in repos such as benchmark
for benchmark runs