Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the te fuser setup #963

Closed
wants to merge 2 commits into from
Closed

Fix the te fuser setup #963

wants to merge 2 commits into from

Conversation

xuzhao9
Copy link
Contributor

@xuzhao9 xuzhao9 commented Jun 15, 2022 •
edited
Loading

Correctly enable te fuser environment when fuser is specified as te.
Fixes #956

@xuzhao9 xuzhao9 mentioned this pull request Jun 15, 2022
Closed
@LSC527
Copy link

LSC527 commented Jun 16, 2022

I don't know much about these torch._C. variables. One thing to be mention is that set torch._C._jit_set_nvfuser_enabled(False) can turn off nvfuser.

davidberard98
davidberard98 approved these changes Jun 16, 2022
View reviewed changes
Copy link
Contributor

@davidberard98 davidberard98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I would just suggest turning on NNC cpu fusion by default as well.

conftest.py Outdated Show resolved Hide resolved
@facebook-github-bot
Copy link
Contributor

@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

3 similar comments
@facebook-github-bot
Copy link
Contributor

@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@xuzhao9 xuzhao9 deleted the xz9/fix-default-fuser branch June 20, 2022 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidberard98 davidberard98 davidberard98 approved these changes

@eellison eellison Awaiting requested review from eellison

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NVFuser is the default fuser for Nvidia GPU now
4 participants
@xuzhao9 @LSC527 @facebook-github-bot @davidberard98