Record PyTorch git version and cuda version in the result. #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wconstab
reviewed
Mar 11, 2021
| @@ -42,6 +42,9 @@ def pytest_configure(config): | |||
|
|
|||
| def pytest_benchmark_update_machine_info(config, machine_info): | |||
| machine_info['pytorch_version'] = torch.__version__ | |||
| machine_info['pytorch_git_version'] = torch.version.git_version | |||
| machine_info['cuda_version'] = torch.version.cuda | |||
There was a problem hiding this comment.
is this safe (in cases where not torch.has_cuda)?
There was a problem hiding this comment.
If cuda is not available, torch.version.cuda will be None (tested on my macbook). Do you think it is fine?
wconstab
approved these changes
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CUDA version information is useful if we want to abtest CUDA regression in the future.
Adding PyTorch git version to easier nail down the exact commit used by TorchBench.