Make sure diagnostic variables aren't set when benchmarking #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Krovatkin
force-pushed
the
krovatkin/check_env
branch
from
fecbebe
to
936a20f
Compare
wconstab
reviewed
Feb 4, 2021
conftest.py
Outdated
| @@ -25,8 +25,21 @@ def set_fuser(fuser): | |||
| torch._C._jit_override_can_fuse_on_gpu(True) | |||
| torch._C._jit_set_texpr_fuser_enabled(True) | |||
|
|
|||
| def check_environment(): | |||
| checks = [ | |||
| # VAR_NAME, forbidden value | |||
There was a problem hiding this comment.
shouldn't this read VAR_NAME, required value?
sounds backward to me. IIUC you want to make sure logging is off, for instance?
wconstab
reviewed
Feb 4, 2021
| def pytest_sessionstart(session): | ||
| try: | ||
| check_environment() |
There was a problem hiding this comment.
What do you think about moving this check into the util file, and calling check_environment from inside check_machine_configured? Any reason to separate them?
wconstab
approved these changes
Feb 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.