Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plots variable along 1 input parameter to jagged_sum operator in TritonBench #2340

Closed
wants to merge 1 commit into from

Conversation

jananisriram
Copy link
Contributor

Summary:
Add plotting functionality to the jagged_sum operator in TritonBench, enabling the creation of line plots for any set of benchmarks variable along one of the following input parameters: B, M, seqlen, or sparsity. This diff makes it easier to visualize the differences in latency among the different benchmarks in the jagged_sum operator.

Add a command-line argument to toggle the benchmarks displayed on the plots, making it easier to visualize just the 2 Triton benchmarks or just the 2 PyTorch benchmarks, if necessary. This modification helps more clearly visualize the latency differences between the simple fused and variable-length loop Triton kernels as well as the unpadded and padded PyTorch benchmarks.

Reviewed By: davidberard98

Differential Revision: D59034792

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59034792

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59034792

jananisriram added a commit to jananisriram/benchmark that referenced this pull request Jun 27, 2024
…TritonBench (pytorch#2340)

Summary:
Pull Request resolved: pytorch#2340

Add plotting functionality to the `jagged_sum` operator in TritonBench, enabling the creation of line plots for any set of benchmarks variable along one of the following input parameters: `B`, `M`, `seqlen`, or `sparsity`. This diff makes it easier to visualize the differences in `latency` among the different benchmarks in the `jagged_sum` operator.

Add a command-line argument to toggle the benchmarks displayed on the plots, making it easier to visualize just the 2 Triton benchmarks or just the 2 PyTorch benchmarks, if necessary. This modification helps more clearly visualize the `latency` differences between the simple fused and variable-length loop Triton kernels as well as the unpadded and padded PyTorch benchmarks.

Reviewed By: davidberard98

Differential Revision: D59034792
…TritonBench

Summary:
Add plotting functionality to the `jagged_sum` operator in TritonBench, enabling the creation of line plots for any set of benchmarks variable along one of the following input parameters: `B`, `M`, `seqlen`, or `sparsity`. This diff makes it easier to visualize the differences in `latency` among the different benchmarks in the `jagged_sum` operator.

Add a command-line argument to toggle the benchmarks displayed on the plots, making it easier to visualize just the 2 Triton benchmarks or just the 2 PyTorch benchmarks, if necessary. This modification helps more clearly visualize the `latency` differences between the simple fused and variable-length loop Triton kernels as well as the unpadded and padded PyTorch benchmarks.

Note that for plots testing multiple values of `B` or `M`, the x-axis is on a log scale to more accurately depict trends in latency; whether or not the x-axis is on a log scale is noted in the plot name in the Test Plan.

Reviewed By: davidberard98

Differential Revision: D59034792
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59034792

@facebook-github-bot
Copy link
Contributor

Hi @jananisriram!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@kit1980
Copy link
Member

kit1980 commented Aug 13, 2024

This is already in main as 847d38e, closing.

@kit1980 kit1980 closed this Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants