Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the ci by separating CPU and CUDA tests #2327

Closed
wants to merge 9 commits into from
Closed

Conversation

xuzhao9
Copy link
Contributor

@xuzhao9 xuzhao9 commented Jun 21, 2024

Currently we are running both CPU and CUDA tests in the A100/A10G runners. This is a waste of resource.
In this PR, we separate CPU and CUDA tests with different runners. The CUDA tests still run on the GCP A100 runner, while the CPU tests runs on a CPU-only runner of linux.24xlarge.

Reduces the CI time from ~120m to ~90m.

Fixes #2135

@xuzhao9 xuzhao9 requested a review from huydhn June 22, 2024 00:27
@facebook-github-bot
Copy link
Contributor

@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@facebook-github-bot
Copy link
Contributor

@xuzhao9 merged this pull request in 1f98239.

@xuzhao9 xuzhao9 deleted the xz9/improve-ci branch June 26, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use CPU-only instance to run the CPU tests
3 participants