Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the soft_actor_critic model #2326

Closed
wants to merge 2 commits into from
Closed

Fix the soft_actor_critic model #2326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
76489bd
Fix the CI
xuzhao9 Jun 21, 2024
967e746
Fix sac
xuzhao9 Jun 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions torchbenchmark/models/soft_actor_critic/nets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
from torch import distributions as pyd
from torch import nn

from . import utils
from . import sac_utils
from torchbenchmark.util.distribution import SquashedNormal

def weight_init(m):
Expand All @@ -30,11 +30,11 @@ def __init__(self, obs_shape, out_dim=50):
self.conv3 = nn.Conv2d(32, 32, kernel_size=3, stride=1)
self.conv4 = nn.Conv2d(32, 32, kernel_size=3, stride=1)

output_height, output_width = utils.compute_conv_output(
output_height, output_width = sac_utils.compute_conv_output(
obs_shape[1:], kernel_size=(3, 3), stride=(2, 2)
)
for _ in range(3):
output_height, output_width = utils.compute_conv_output(
output_height, output_width = sac_utils.compute_conv_output(
(output_height, output_width), kernel_size=(3, 3), stride=(1, 1)
)

Expand Down Expand Up @@ -63,15 +63,15 @@ def __init__(self, obs_shape, out_dim=50):
self.conv2 = nn.Conv2d(32, 64, kernel_size=4, stride=2)
self.conv3 = nn.Conv2d(64, 64, kernel_size=3, stride=1)

output_height, output_width = utils.compute_conv_output(
output_height, output_width = sac_utils.compute_conv_output(
obs_shape[1:], kernel_size=(8, 8), stride=(4, 4)
)

output_height, output_width = utils.compute_conv_output(
output_height, output_width = sac_utils.compute_conv_output(
(output_height, output_width), kernel_size=(4, 4), stride=(2, 2)
)

output_height, output_width = utils.compute_conv_output(
output_height, output_width = sac_utils.compute_conv_output(
(output_height, output_width), kernel_size=(3, 3), stride=(1, 1)
)

Expand Down
2 changes: 1 addition & 1 deletion torchbenchmark/models/soft_actor_critic/sac.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import numpy as np
import torch

from . import envs, nets, replay, utils
from . import envs, nets, replay, sac_utils


class SACAgent:
Expand Down
Loading