Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcode the numpy version #2316

Closed
wants to merge 6 commits into from
Closed

Hardcode the numpy version #2316

wants to merge 6 commits into from

Conversation

xuzhao9
Copy link
Contributor

@xuzhao9 xuzhao9 commented Jun 19, 2024

When there is a big numpy version bump (1.21.2 -> 2.0.0), pip install will somehow automatically upgrade numpy version to 2.0.0 even when the old version (1.21.2) has been installed.

Therefore, we have to hardcode numpy version both globally and for the models whose install will cause numpy to unexpectedly upgrade. Since downstream CI supports Python 3.8 as the lowest supported Python version, we have to pin numpy version to the lowest version used in the downstream CI.

@facebook-github-bot
Copy link
Contributor

@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@xuzhao9
Copy link
Contributor Author

xuzhao9 commented Jun 19, 2024

We probably can add a constraint to the numpy version by dynamically adding a numpy_constraint.txt file during the installation.

I think it is reasonable to guarantee that numpy version does not change when the models are being installed.

@facebook-github-bot
Copy link
Contributor

@xuzhao9 merged this pull request in 62e2609.

@xuzhao9 xuzhao9 deleted the xz9/fix-numpy-2 branch June 19, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants